Question

I want do this:

sender_email = @request.user.paypal_email if @request.user.paypal_email == "[e-mail]"

So basically I want to only execute the command if the users paypal email is "[e-mail]". This works fine but it seems like there is room for refactoring.

Answer 1

Since this code is in your controller, then it can definitely be refactored. You typically want logic like this to be in the models since it’s easy to write unit tests and it’s not the job of the controller to know so much about the user model.

There’s a few ways you could refactor this, but I would recommend moving the logic to the user model like so:

def User < ActiveRecord::Base
  def sender_email
    paypal_email if paypal_email == "[e-mail]"
  end
end

Then your controller wouldn’t need to know as much and could just do:

sender_email = @request.user.sender_email