Question

I want to delete/remove an object from an array list of objects. Would this work if my class was:

class bookings {
  public String getuser () {
    return user;
  }

  public Date getbooking() {
    return bookingDate;
  }

  private String user;
  private Date bookingDate;
}

and I had an arraylist similar to:

ArrayList <bookings> book;


public void foo (String user, Date date) {
  for (bookings b : book) {
    if (user.equals(b.getuser()) && date.equals(g.getbooking()) book.remove(b);
  }
}

Answer 1

Firstly, you can’t use a foreach loop for (bookings b : book) because it won’t allow you to modify the collection (it will throw an exception).

This code should work:

public void foo (String user, Date date) {
  for (Iterator<bookings> i = book.iterator(); i.hasNext();) {
    bookings b = i.next(); // Oops - forgot this line!
    if (user.equals(b.getuser()) && date.equals(b.getbooking())
        i.remove(); // Corrected this too!
  }
}

It wouldn’t hurt to name things using standard naming conventions and capitalization either:

class Booking {
    String getUser() ...
    Date getDate() ...
}

ArrayList<Booking> bookings;