Question

i want to validate all inputs using class name i’m using following code

$('#submitbutton').click(function() {

           $('input.inputme[type=hidden]').each(function () {

                 if($(this).val()==''){
                     choclates='false';
                 }else{
                      choclates='true';
                     }                      
            });
         if(choclates=='true'){
                  $('#choclateform').submit();
                 }else{
                 alert("Please Fill all Boxes.");
                 }

        });

when i posted this question code was different and was not working full but this works but i think i’m making it complicated can someone make it better ?

Answer 1

If your goal is to prevent a form from being submitted, I’d hook the submit event on the form instead, and return false from that handler when blank fields are found (to prevent the form being submitted).

// Hook the submit event
$('#theForm').submit(function() {
    // Assume all will be fine
    var valid = true;

    // Check your inputs
    $('input.inputme[type=text]').each(function () {

        // Is this input's value (effectively) blank? Note that
        // there's no reason whatsoever to use $(this).val(),
        // with text fields this.value gives you the same thing
        // more efficiently.
        // I'm also trimming off whitespace and using the fact
        // that empty strings are "falsey".
        if (!$.trim(this.value)) {
            // Bug user
            alert("Please fill all boxes");

            // Flag that there was a problem
            valid = false;

            // Optionally, stop the `each` loop. If
            // you're *literally* going to use `alert`,
            // then I'd stop the loop or you'll irritate
            // people. But if you're showing some kind
            // of indicator next to the field instead,
            // then I'd leave this off and continue to do
            // all fields.
            return false;
        }
    });

    if (!valid) {
        // Cancel submission
        return false;
    }
});