Question

I wanted to double check that I was doing correct memory management. Is this correct? Do I have the correct amount of releases.

In my .h file:

UITableView *_sortOrderTableView;
@property (nonatomic, retain) UITableView *SortOrderTableView;

In my .m file:

In dealloc

 [_sortOrderTableView release];

My code that presents the popover is this:

- (IBAction)sortButtonOrderPressed:(id)sender {
    UIViewController *sortOrderController = [[UIViewController alloc] init];

    self.SortOrderTableView = [[UITableView alloc] initWithFrame:CGRectMake(0, 0, 200, 100)];
self.SortOrderTableView.backgroundColor = [UIColor colorWithPatternImage:[UIImage imageNamed:@"App_Background.png"]];
self.SortOrderTableView.bounces = NO;
self.SortOrderTableView.scrollEnabled = NO;
    sortOrderController.view = self.SortOrderTableView;
    sortOrderController.contentSizeForViewInPopover = CGSizeMake(200, 100);
    self.SortOrderTableView.delegate = self;
    self.SortOrderTableView.dataSource = self;

    self.SortPopover = [[UIPopoverController alloc] initWithContentViewController:sortOrderController];
    [self.SortPopover presentPopoverFromRect:_sortButtonOrder.frame inView:self.view permittedArrowDirections:UIPopoverArrowDirectionAny animated:YES];

    [self.SortOrderTableView release];
    [sortOrderController release];
}

Answer 1

Remove [self.SortOrderTableView release];, it should be [_sortOrderTableView release]; or self.SortOrderTableView = nilanyway, but you’re already calling that in your dealloc method, so there is no need to release it here. If you want to release it though, use self.SortOrderTableView = nil.

Apart from that you will also have to release your SortPopover’s instance variable in your dealloc method.