Question

I was reading Steven Sanderson’s book Pro ASP.NET MVC Framework and he suggests using a repository pattern:

public interface IProductsRepository
{
    IQueryable<Product> Products { get; }
    void SaveProduct(Product product);
}

He accesses the products repository directly from his Controllers, but since I will have both a web page and web service, I wanted to have add a “Service Layer” that would be called by the Controllers and the web services:

public class ProductService
{
    private IProductsRepository productsRepsitory;

    public ProductService(IProductsRepository productsRepository)
    {
        this.productsRepsitory = productsRepository;
    }

    public Product GetProductById(int id)
    {
        return (from p in productsRepsitory.Products
                where p.ProductID == id
                select p).First();
    }

    // more methods
}

This seems all fine, but my problem is that I can’t use his SaveProduct(Product product) because:

1) I want to only allow certain fields to be changed in the Product table

2) I want to keep an audit log of each change made to each field of the Product table, so I would have to have methods for each field that I allow to be updated.

My initial plan was to have a method in ProductService like this:

public void ChangeProductName(Product product, string newProductName);

Which then calls IProductsRepository.SaveProduct(Product)

But there are a few problems I see with this:

1) Isn’t it not very “OO” to pass in the Product object like this? However, I can’t see how this code could go in the Product class since it should just be a dumb data object. I could see adding validation to a partial class, but not this.

2) How do I ensure that no one changed any other fields other than Product before I persist the change?

I’m basically torn because I can’t put the auditing/update code in Product and the ProductService class’ update methods just seem unnatural (However, GetProductById seems perfectly natural to me).

I think I’d still have these problems even if I didn’t have the auditing requirement. Either way I want to limit what fields can be changed in one class rather than duplicating the logic in both the web site and the web services.

Is my design pattern just bad in the first place or can I somehow make this work in a clean way?

Any insight would be greatly appreciated.

Answer 1

I split the repository into two interfaces, one for reading and one for writing.

The reading implements IDisposeable, and reuses the same data-context for its lifetime. It returns the entity objects produced by linq to SQL. For example, it might look like:

interface Reader : IDisposeable
{
    IQueryable<Product> Products;
    IQueryable<Order> Orders;
    IQueryable<Customer> Customers;
}

The iQueryable is important so I get the delayed evaluation goodness of linq2sql. This is easy to implement with a DataContext, and easy enough to fake. Note that when I use this interface I never use the autogenerated fields for related rows (ie, no fair using order.Products directly, calls must join on the appropriate ID columns). This is a limitation I don’t mind living with considering how much easier it makes faking read repository for unit tests.

The writing one uses a separate datacontext per write operation, so it does not implement IDisposeable. It does NOT take entity objects as input or out- it takes the specific fields needed for each write operation.

When I write test code, I can substitute the readable interface with a fake implementation that uses a bunch of List<>s which I populate manually. I use mocks for the write interface. This has worked like a charm so far.

Don’t get in a habit of passing the entity objects around, they’re bound to the datacontext’s lifetime and it leads to unfortunate coupling between your repository and its clients.