Question

I was trying to find the anomolies in the below code but i couldn’t find anything except bad naming convention.

public static Response DoIt(ADUser user)
{
    string search = "(cn=" + user.name.Trim() + ")";
    // More code lines
}

Answer 1

Its not returning an Response type object, other than that it is fine. You may replace strings in double quotes ("(cn=") with constant if you are using it in more than one place. If you are worried about concatenation of string in a single line, then it is OK. But if you need to concatenate string search within a loop or something that requires to much concatenation then you may consider using StringBuilder to build your string.