Question

I was using this to generate RSS to post to my facebook wall… but in the last 24 hours it stopped working. I think that the feed pushing service i use became strict with the RSS validation. This doesnt validate… and i cant get it too. Can anyone suggest changes to make this work? I know this probably looks VERY messy! :os

Thanks in advance.

<?php do { ?>
<item>
<title><![CDATA[<?php echo htmlentities(strip_tags(addslashes($row_getDresses['listing_title']))); ?><?php if($_GET['type'] == "reduced-dresses"){?> (REDUCED BY <?php echo $row_getDresses['symbol'];?><?php echo $row_getDresses['reduced_price'];?> <?php echo $row_getDresses['dress_currency'];?>)<?php } else {?> (<?php echo $row_getDresses['symbol'];?><?php echo $row_getDresses['price'];?> <?php echo $row_getDresses['dress_currency'];?>)<?php }?>]]></title>
<link><![CDATA[http://www.asite.com/dress/<?php echo $row_getDresses['listing_tidy_url'];?>-<?php echo $row_getDresses['dress_id'];?>.html]]></link>
<description><![CDATA[<?php echo substr(strip_tags(addslashes(trim($row_getDresses['dress_desc'])),'ENT_QUOTES'),0,100);?>]]>...</description>
<?php if (isset($row_getDresses['main_image']) && file_exists("../listing-images/".$row_getDresses['main_image']."")) { ?>
<enclosure url="http://www.asite.com/listing-images/<?php echo $row_getDresses['main_image'];?>" length="<?php echo filesize("../listing-images/".$row_getDresses['main_image']."");?>" type="image/jpeg">
<?php }?>
<?php if ($_GET['type'] == "reduced-dresses"){?>
<pubDate><?php echo $row_getDresses['date_updated'];?> GMT</pubDate>
<?php } else { ?>
<pubDate><?php echo $row_getDresses['date_added'];?> GMT</pubDate>
<?php }?>
<category><?php echo htmlentities($pageTitle);?></category>
</item>
<?php } while ($row_getDresses = mysql_fetch_assoc($getDresses)); ?>

Answer 1

you dosn’t close the enclosure-tag, add a </enclosure> or just add a / at the end of the tag like <enclosure ... />

Update
and readability was horible, here is an exemple at your code in my coding-style:

<?php

   do
   {
      /* preper data */
      $category = htmlentities($pageTitle);
      $link = "http://www.asite.com/dress/{$row_getDresses['listing_tidy_url']}-{$row_getDresses['dress_id']}.html";
      $description = substr(strip_tags(addslashes(trim($row_getDresses['dress_desc'])),'ENT_QUOTES'),0,100);
      $title = htmlentities(strip_tags(addslashes($row_getDresses['listing_title'])));

      /* Reduced price? */
      if($_GET['type'] == "reduced-dresses")
      {
         $title .= " (REDUCED BY {$row_getDresses['symbol']}{$row_getDresses['reduced_price']} {$row_getDresses['dress_currency']})";
         $date = $row_getDresses['date_updated'];
      }
      else
      {
         $titlt .= " ({$row_getDresses['symbol']}{$row_getDresses['price']} {$row_getDresses['dress_currency']})";
         $date = $row_getDresses['date_added'];
      }

      /* image exists? */
      if(isset($row_getDresses['main_image']) AND file_exists("../listing-images/".$row_getDresses['main_image'].""))
      {
         $image = "http://www.asite.com/listing-images/{$row_getDresses['main_image']}";
         $image_size = filesize("../listing-images/".$row_getDresses['main_image']."");
      }
      else
      {
         $image = FALSE;
      }


      /* write RSS */
      echo "<item>";
      echo "<title><![CDATA[{$title}]]></title>";
      echo "<link><![CDATA[{$link}]]></link>";
      echo "<description><![CDATA[{$description}]]>...</description>";

      if($image)
      {
         echo "<enclosure url='{$image}' length='{$image_size}' type='image/jpeg' />";
      }

      echo "<pubDate>{$date} GMT</pubDate>";
      echo "<category>{$category}</category>";
      echo "</item>";

   } while ($row_getDresses = mysql_fetch_assoc($getDresses));

?>