Question

I was wondering if this approach was correct :

public ITask getState()
{
    statePredicate[Some predicate definition];
    ITask nextRunnable = null;
try {
    nextRunnable = Iterables.find((Iterable)queue, statePredicate);
} 
    catch (NoSuchElementException e) 
    {}
return nextRunnable;
}

The points on which I am wondering are :

• should the predicate be cached as a member of the class ?
• I do nothing with the catch, I do not even log it because it is
  normal for my app to not find anything.
• t return null because I do a final return.

Thank you for your input !
–

Answer 1

1) If the predicate is always the same, I would make it a static final class member.

2) There is also a version of Iterables.find that you can specify a default value to (assuming you’re using Google Guava). Then you don’t need to deal with the NoSuchElementException at all.

3) Is there a reason to cast queue to Iterable? If this is not necessary, then don’t cast.

class MyClass {
    private static final Predicate STATE_PREDICATE = new Predicate<ITask>() {
        @Override
        public boolean apply(ITask input) {
            // ... your code here
        }
    };

    public ITask getState() {
        return Iterables.find(queue, STATE_PREDICATE, null);
    }
}