Question

I was wondering which of the following examples is more accepted within the Python community:

1.

return any(host[0].endswith(bot_hosts) for bot_hosts in bot_hosts)

2.

if any(host[0].endswith(bot_hosts) for bot_hosts in bot_hosts):
    return True
else:
    return False

Or maybe something else?

Please advise.

Answer 1

In your example case: str.endswith takes tuple as an argument. Overall, as a design pattern use the first version (check the reasoning @Ben’s answer).
That is any(host[0].endswith(bot_host) for bot_host in bot_hosts) is the same as:

host[0].endswith(bot_hosts) #if bot_hosts is a tuple
                            #if bot_hosts in not a tuple add tuple(bot_hosts)

Example:

In [1]: suffs = ('a','b','d')

In [2]: 'asd'.endswith(suffs)
Out[2]: True

In [3]: 'asap'.endswith(suffs)
Out[3]: False