Question

I wonder if there any more pythonic way to write this function:

def parse(filename):
    with open(filename, 'r', encoding='koi8-r') as f:
        for log_line in f:
            for s in services:
                if ' ' + s + ' ' in log_line:
                    print(s)
                    services.remove(s)

Answer 1

Use sets:

def parse(filename):
    servicesset = set(services)
    with open(filename, 'r', encoding='koi8-r') as f:
        for log_line in f:
            words = set(log_line.split())
            servicesset -= words

    services[:] = list(servicesset)

This presumes the services global is a list. Note that it’d be much better to pass in services then return the result:

def parse(filename, services):
    services = set(services)
    with open(filename, 'r', encoding='koi8-r') as f:
        for log_line in f:
            words = set(log_line.split())
            services -= words

    return list(servicesset)