Question

I would like to return multiple values from stored procedure (attached as below) by having userid as parameter. I tried to receive the multiple values by using function with dataset (attached as below) but failed and I got the error lists like this:

Error 2 Argument ‘2’: cannot convert from ‘System.Data.SqlClient.SqlConnection’ to ‘string’

Error 5 The best overloaded method match for ‘System.Data.SqlClient.SqlDataAdapter.SqlDataAdapter(string, System.Data.SqlClient.SqlConnection)’ has some invalid arguments

Error 6 Argument 1: cannot convert from ‘System.Data.SqlClient.SqlCommand’ to ‘string’

Appreciate for any reply. Million thanks.

SQL:

ALTER PROCEDURE abc.testing

@userid int

AS

SELECT * FROM ss2_table
WHERE userid=@userid

C#:

public DataSet get_testing(int userid)
{
    DataSet ds_testing_total = null;
    using (SqlConnection connection = new SqlConnection(@"Userid=abc;Password=abc;Server=admin;Database=ss2"))
    {
        try
        {
            SqlCommand cmdselect1 = new SqlCommand();
            cmdselect1.CommandType = CommandType.StoredProcedure;
            cmdselect1.CommandText = "abc.testing";
            cmdselect1.Parameters.Add("@userid", SqlDbType.Int, 4).Value = userid;
            cmdselect1.Connection = connection;
            connection.Open();


            SqlDataAdapter dap1 = new SqlDataAdapter(cmdselect1, connection);
            ds_testing_total = new DataSet();
            dap1.Fill(ds_testing_total, "ss2_table");

            return ds_testing_total;
        }
        catch (Exception ex)
        {
            Console.WriteLine("Commit Exception Type: {0}", ex.GetType());
            Console.WriteLine("  Message: {0}", ex.Message);
        }
    }
}

---

Answer 1

Should be:

SqlDataAdapter dap1 = new SqlDataAdapter(cmdselect1.CommandText, connection);

-or-

SqlDataAdapter dap1 = new SqlDataAdapter(cmdselect1);

Not:

SqlDataAdapter dap1 = new SqlDataAdapter(cmdselect1, connection);

Also, you can create a new SqlCommand by using connection.CreateCommand() rather than new SqlCommand() and setting the connection.

SqlCommand cmdselect1 = connection.CreateCommand();