Question

I wrote a pretty simple function that reads in possible player names and stores them in a map for later use. Basically in the file, each line is a new possible player name, but for some reason it seems like all but the last name has some invisible new line character after it. My print out is showing it like this…

nameLine = Georgio

Name: Georgio
 0
nameLine = TestPlayer

Name: TestPlayer 0

Here is the actual code. I assume I need to be stripping something out but I am not sure what I need to be checking for.

bool PlayerManager::ParsePlayerNames()
{
    FileHandle_t file;
    file = filesystem->Open("names.txt", "r", "MOD");

    if(file)
    {
        int size = filesystem->Size(file);
        char *line = new char[size + 1];

        while(!filesystem->EndOfFile(file))
        {
            char *nameLine = filesystem->ReadLine(line, size, file);

            if(strcmp(nameLine, "") != 0)
            {
                Msg("nameLine = %s\n", nameLine);
                g_PlayerNames.insert(std::pair<char*, int>(nameLine, 0));
            }

            for(std::map<char*,int>::iterator it = g_PlayerNames.begin(); it != g_PlayerNames.end(); ++it)
            {
                Msg("Name: %s %d\n", it->first, it->second);
            }
        }

        return true;
    }

    Msg("[PlayerManager] Failed to find the Player Names File (names.txt)\n");
    filesystem->Close(file);
    return false;
}

Answer 1

ReadLine clearly includes the newline in the data it returns. Simply check for and remove it:

char *nameLine = filesystem->ReadLine(line, size, file);

// remove any newline...
if (const char* p_nl = strchr(nameLine, '\n'))
    *p_nl = '\0';

(What this does is overwrite the newline character with a new NUL terminator, which effectively truncates the ASCIIZ string at that point.