Question

i wrote following code to count occurance of characters in given char array

#include <iostream>
#include <string>
using namespace std;
int main(){

char f[]={'a','a','b','c','c','d','d','f','e','e'};
int n=sizeof(f)/sizeof(char);
char max=f[0];
for (int i=1;i<n;i++)
{
    if(f[i]>max)
    {
        max=f[i];
    }
}

int m=(int)(max)+1;
int  *b=new int [m];

for (int i=0;i<n;i++)
{
    b[(int)(f[i])]++;
}

for (int i=0;i<m;i++)
{
    if(b[i]!=0)
    {
    cout<<(char)(i)<<" occurs  "<<b[i]<< "times "<<endl;   
    }      
}

return 0;
}

but it shows very bad result

 occurs  -842150451times
☺ occurs  -842150451times
☻ occurs  -842150451times
♥ occurs  -842150451times
♦ occurs  -842150451times
♣ occurs  -842150451times
♠ occurs  -842150451times
 occurs  -842150451times
 occurs  -842150451times
         occurs  -84215045

 occurs  -842150451times
♂ occurs  -842150451times
♀ occurs  -842150451times
 occurs  -842150451times
♫ occurs  -842150451times
☼ occurs  -842150451times
► occurs  -842150451times
◄ occurs  -842150451times
↕ occurs  -842150451times
‼ occurs  -842150451times
¶ occurs  -842150451times
§ occurs  -842150451times
▬ occurs  -842150451times
↨ occurs  -842150451times
↑ occurs  -842150451times
↓ occurs  -842150451times
→ occurs  -842150451times
← occurs  -842150451times
∟ occurs  -842150451times
↔ occurs  -842150451times
▲ occurs  -842150451times
▼ occurs  -842150451times
  occurs  -842150451times
! occurs  -842150451times
" occurs  -842150451times
# occurs  -842150451times
$ occurs  -842150451times
% occurs  -842150451times
& occurs  -842150451times
' occurs  -842150451times
( occurs  -842150451times
) occurs  -842150451times
* occurs  -842150451times
+ occurs  -842150451times
, occurs  -842150451times
- occurs  -842150451times
. occurs  -842150451times
/ occurs  -842150451times
0 occurs  -842150451times
1 occurs  -842150451times
2 occurs  -842150451times
3 occurs  -842150451times
4 occurs  -842150451times
5 occurs  -842150451times
6 occurs  -842150451times
7 occurs  -842150451times
8 occurs  -842150451times
9 occurs  -842150451times
: occurs  -842150451times
; occurs  -842150451times
< occurs  -842150451times
= occurs  -842150451times
> occurs  -842150451times
? occurs  -842150451times
@ occurs  -842150451times
A occurs  -842150451times
B occurs  -842150451times
C occurs  -842150451times
D occurs  -842150451times
E occurs  -842150451times
F occurs  -842150451times
G occurs  -842150451times
H occurs  -842150451times
I occurs  -842150451times
J occurs  -842150451times
K occurs  -842150451times
L occurs  -842150451times
M occurs  -842150451times
N occurs  -842150451times
O occurs  -842150451times
P occurs  -842150451times
Q occurs  -842150451times
R occurs  -842150451times
S occurs  -842150451times
T occurs  -842150451times
U occurs  -842150451times
V occurs  -842150451times
W occurs  -842150451times
X occurs  -842150451times
Y occurs  -842150451times
Z occurs  -842150451times
[ occurs  -842150451times
\ occurs  -842150451times
] occurs  -842150451times
^ occurs  -842150451times
_ occurs  -842150451times
` occurs  -842150451times
a occurs  -842150449times
b occurs  -842150450times
c occurs  -842150449times
d occurs  -842150449times
e occurs  -842150449times
f occurs  -842150450times

please help me what is wrong?

Answer 1

You have to initalize the “malloc”ed (new) area to 0, it contains garbage.