Question

I wrote the following algorithm for finding all possible permutations of n unique alphabets.

Set<String> results = new HashSet<String>();
    int size = 1;
            //find the total permutations possible
    for(int i=0;i<array.length;i++){
        size*=(i+1);            
    }
    // i is the number of items remaining to be shuffled.
    while(results.size()<size){
        for (int i = array.length; i > 1; i--) {
            // Pick a random element to swap with the i-th element.
            int j = rng.nextInt(i);  // 0 <= j <= i-1 (0-based array)
            // Swap array elements.
            char tmp = array[j];
            array[j] = array[i-1];
            array[i-1] = tmp;
        }
        StringBuffer str = new StringBuffer();          
        for(int i=0;i<array.length;i++)
            str.append(array[i]);
        results.add(str.toString());
    }
    System.out.println(results);

1) Is there anything to be done to improve this algorithm?
2) What would be the time complexity of this algorithm?

PS: I apologize to the people who who reacted to my previous post. I’ll try on my own before asking for help.

Answer 1

By utilizing a random shuffling, you’re going to have a massive number of iterations that end up not actually putting a new item into the set – you should look for an approach that ensures that on each iteration a new item is placed into the set (by ‘new’ I simply mean a permutation that hasn’t been seen previously).

I wouldn’t like to guess at the time complexity of the algorithm supplied above – it’s going to be big.