Question

I’d like some help please, if its possible.

I have created two functions in order to display some messages when is set a $_GET after a redirect.Here’s the code:

function display(){
if(isset($_GET['cnf_upd']) && $_GET['cnf_upd'] == '1'){
  $value = "The update was successful!";
  $type = "confirm";
  construct_the_div($value, $type);
}
if(isset($_GET['err_upd']) && $_GET['err_upd'] == '1'){
  $value = "The Update failed.";
  $type = "error";
  construct_the_div($value, $type);
}
if(isset($_GET['cnf_del']) && $_GET['cnf_del'] == '1'){
  $value = "Deleted completely.";
  $type = "confirm";
  construct_the_div($value, $type);
}
if(isset($_GET['err_del']) && $_GET['err_del'] == '1'){
  $value = "Unable to delete.";
  $type = "error";
  construct_the_div($value, $type);
}
}
function construct_the_div($value, $type){
// creating a div to display the message results
$div = "<div class=\"{$type}Msg\">\n";
$div .= "<p>{$value}</p>\n";
$div .= "</div><!-- end of {$type}Msg -->\n";
echo $div;
}

What I’d like to make is to try to improve the display function, as it gets longer and longer, so that there whould be only one (or two at most) if statement(s) if possible. So the value of the GET will be dynamicly inside the if condition and also if it has the preffix ‘cnf_’ it wil be a ‘confirmMsg’ and if it has the preffix ‘err_’ it wil be a ‘errorMsg’.

Is it possible to make something like this???

Answer 1

function display() {
    $messages = array(
        'cnf_upd' => 'The update was successful!',
        'cnf_err' => 'The Update failed.!',
        // ...
        // add all error and confirm there
        // ...
    );
    foreach($_GET as $key => $value) {

        if(strpos($key, 'cnf_')===0) {
            $type = 'confirm';
            $value = isset($messages[$key])
                ? $messages[$key]
                : $key;
            construct_the_div($value, $type);
        }

        if(strpos($key, 'err_')===0) {
            $type = 'error';
            $value = isset($messages[$key])
                ? $messages[$key]
                : $key;
            construct_the_div($value, $type);
        }

    }
}