Question

If a class has a constructor which takes some value object as parameter and relies on this to do its initialization. How should it react if this object is null?

class SomeClass
{
    private SomeData _data; 
    public SomeClass(SomeValueObject obj)
    {
        _data = obj.Data;
    }
}

This is one example, but in general: How should a constructor act if it is given invalid parameters and therefore cannot do the construction properly? Should it just return without doing any initialization? Set the parameters to some default values? Throw an exception? Something else?

I’m sure the answer to this is “It depends”, but are there any best practices etc?

Answer 1

A programmer should be able to assume an object was successfully created, unless an exception is raised. The type of exception depends on the argument, but should nonetheless be unchecked. The last thing you want is the constructor fail to build a valid object and not tell the caller about it.

I think using default values in a constructor is a dangerous habit.