Question

If I have a User class, and his account can be suspended by adding an entry to the suspensions table, which of these class/method signatures do you think is more appropriate?

User::suspend($reason, $expiryDate);
Suspension::add($userid, $reason, $expiryDate);

This is a simple example, but I have this kind of situation everywhere throughout my application. On one hand, I’d want to make it a method of the User object, since the action performed is directly related to that user object itself, but on the other hand making it a method on the suspension object seems a bit cleaner.

What do you think?

Answer 1

you suspend a user.

User.Suspend()

In your User.Suspend method, you can actually add them to your “suspension” table, or call your suspension object. This will lead to a cleaner interface since all you have to do is call the one method.