Question

I’m a bit new to programming so the answer to my problem has not become obvious, although I have tried to accomplish the task a number of ways.

The issue is that I’m trying to take an array of words, remove any punctuation from the array, and place the new words into a separate array. I attempted to do this but I keep getting garbage values when I output the new array.

The code reads:

norm(sepwords1,sepwords2,numwords);      <- where I called it in main

void norm(string words[], string wordz[],int count)       
{

        int i;
        int x;
       
        string newstring="";
        char current;
       
         
    for(i=0; i<count; i++)
        {
        for(x=0; x<words[i].length();x++)
        {        
          current= words[i].at(x);
                if(ispunct(current)==0)
                {
                newstring += current;
                }
        
        }        
                wordz[i]= newstring;
        }
 
}

the full main function is:

int main (int argc, char* argv[])
{



int count = argc;
int i;
string filename[count];
ifstream infile;
string fromfile[1000];
int numdata;
int pass;
char current;
int sum;
string masterstring="";
int x;
string sepwords[2000];
int sum1;
string temp="";
int start;
int fin;
string newstring="";
string newfile[1000];
int place;
int numwords;
string sepwords1[2000];
string newmaster="";
int j=0;
string currentz;
string highmark;
int index[2000];
string sepwords2[2000];
int counta=0;

for(i=0; i < count-1; i++) 
{
filename[i] = argv[i+1];
}

for( i=0; i < count-1; i++)
    {
    infile.open(filename[i].c_str());
    
    numdata=0;  
    
    while(!infile.eof())
    {
    
    getline(infile, fromfile[numdata], '\n');
    numdata++;
    
    }


    
    

    for(i=0; i<numdata; i++)
    {
    cout<<fromfile[i]<<endl;
    masterstring += fromfile[i] + " ";                                      //NUMBER ONE
    }

    

    numwords = split(masterstring, sepwords);
    cout<<numwords<<endl;                                                       //NUMBER TWO


    }

    for(i=0;i<numwords;i++)
    {
        newstring = toupper(sepwords[i].at(0));         
        newstring += sepwords[i].substr(1);
        sepwords1[i] = newstring;
        newstring="";
    }
    
    for(i=0;i<numwords;i++)
    {
    
    
    newmaster += sepwords1[i] + " ";
       j++;
          if(j > 10)
          {
           newmaster+= '\n';
           j=0;
          }

    }
    cout<<newmaster<<endl;                                              //NUMBER THREE



    norm(sepwords1,sepwords2,numwords);
    
        for(i=0;i<numwords;i++)
    {
    cout<<sepwords2<<endl;
    }

return 0;
}

Answer 1

Not sure what you mean by gargage output?

If I call your function with this (g++ 4.4.5)

#include <string>
#include <iostream>
using namespace std;
int
main  (int ac, char **av)
{
  int numwords = 3;
  string sepwords1[] = {"one,", "two", "three"};
  string sepwords2[numwords];
  norm(sepwords1,sepwords2,numwords);  
  for(size_t i=0;i<numwords;++i){
    std::cout<<"sepwords2["<<i<<"] = "<<sepwords2[i]<<std::endl;
  }

}

then I get the output

sepwords2[0] = one
sepwords2[1] = onetwo
sepwords2[2] = onetwothree

Is this not what you want?

If you don’t want concatination, then you need to reset the newword variable,

  wordz[i]= newstring;  //this is in your norm function 
  newstring="";         //this is the line I added. 

then the output is

sepwords2[0] = one
sepwords2[1] = two
sepwords2[2] = three