Home/ Questions/Q 9308237
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-06-19T00:34:58+00:00

I’m about to migrate some code to the PSR-2 standard. In my code i

  • 0

I’m about to migrate some code to the PSR-2 standard. In my code i have if statements with multiple lines as expression: 

if (    $field->getBlockMode() == FieldInterface::BLOCK_MODE_HIDEVAR &&
        !isset($this->enabledBlocks[$field->getBlock()])
) {

}

What’s the best practice to write such expressions?

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    How about making it a one-liner to avoid that problem and make the statement more readable:

    $blockModeIsHidevar = $field->getBlockMode() == FieldInterface::BLOCK_MODE_HIDEVAR;
$blockNotEnabled = !isset($this->enabledBlocks[$field->getBlock()]);

if ($blockModeIsHidevar && $blockNotEnabled) {

}

    Alternative:

    I usually do it with methods, this could looke like that:

    if ($this->blockModeIsHidevar($field) && $this->blockNotEnabled($field)) {

}
// ...
private function blockModeIsHidevar($field)
{
    return $field->getBlockMode() == FieldInterface::BLOCK_MODE_HIDEVAR
}
private function blockNotEnabled($field)
{
    return !isset($this->enabledBlocks[$field->getBlock()])
}

    This way, the optimization of && still takes place.

    • 0