Question

I’m checking a session hash for some oAuth values and then setting them if they don’t exist. This is my existing code:

unless session[:oauth][:request_token].nil? && session[:oauth][:request_token_secret].nil?
    @request_token = OAuth::RequestToken.new(@client, session[:oauth][:request_token], session[:oauth][:request_token_secret])
end

…but it’s nasty and doesn’t seem particularly rubyish. Is there a more idiomatic way of writing this?

Answer 1

Perhaps just use some variables?

oauth = session[:oauth]
token, secret = oauth.values_at :request_token, :request_token_secret

if token && secret
  @request_token = OAuth::RequestToken.new(@client, token, secret)
end

Note that I’ve replaced your unless obj.nil? with an if obj since nil is falsy anyway. Unless you expect to have false as a valid value, this is a typical Ruby idiom.