Question

I’m creating some little sprites with a bmp inside the constructor of another view as background. But when I click the sprites, that have their onClickListener, the view I’m clicking is the background view.

Some code:

My constructor:

public ToposGameView(Context context) {
    super(context);

    moles = new ArrayList<MoleSprite>();
    setFocusable(true);
    setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View v) {
            Log.i(tag, "Click en GameView");

        }
    });

    gameLoopThread = new GameLoopThread(this);

    int id = 0;
    for(int x = 0; x<3; x++){
        for(int y = 0; y<4 ; y++){

            MoleSprite mole = new MoleSprite(this, x*WIDTH/3, HEIGHT/6+y*HEIGHT/6, FRONT);
            mole.setId(id);
            id++;
            moles.add(mole);
        }
    }

    holder = getHolder();
    holder.addCallback(new Callback() {

        @Override
        public void surfaceDestroyed(SurfaceHolder arg0) {
            boolean retry=true;
            gameLoopThread.setRunning(false);
            while(retry){
                try{
                    gameLoopThread.join();
                    retry=false;

                }catch(InterruptedException i){

                }
            }
        }

        @Override
        public void surfaceCreated(SurfaceHolder arg0) {
            gameLoopThread.setRunning(true);

            gameLoopThread.start();

        }

        @Override
        public void surfaceChanged(SurfaceHolder arg0, int arg1, int arg2,
                int arg3) {
            // TODO Auto-generated method stub

        }
    });

}

Sprite’s constructor:

public MoleSprite(ToposGameView gameView, int x, int y, int direction) {
    super(gameView.getContext()); //TODO
    bmp = BitmapFactory.decodeResource(getResources(), R.drawable.bad1);
    this.width = bmp.getWidth() / BMP_COLUMNS;      
    this.height = bmp.getHeight() / BMP_ROWS;

    this.x=x;
    this.y= y;

    this.setClickable(true);
    this.setFocusable(true);
    this.setFocusableInTouchMode(true);
    setOnClickListener(this);
    setOnTouchListener(this);
    //I don't know what else to do!
    }

It’s my first question, please ask me for more info.

Edit1:

public class MoleSprite extends View implements OnClickListener, OnTouchListener{

public class ToposGameView extends SurfaceView{

Answer 1

Your mixing Surface drawing with View drawing. Surfaces are great for rapid asynchronous redraws (such as games), but they are not View containers. That is, there is no addView method on SurfaceView that is required for events and layouts.

As such, you will need to implement onClick handling on your SurfaceView and manually implement the detection of which Sprite is being clicked (e.g., is the click event within the sprite’s x/y/width/height bounding box).

Also, it doesn’t make sense for MoleSprite to extend View if used this way. I expect you’ll want to make your own Sprite base class to support the bounding boxes and drawing callbacks. You can also add the onClick(..) interface to the Spirte base class, but you’ll probably also want to keep separate lists for drawable/moveable/clickable items to optimize your list iterations as you develop your game.

Good luck!