Question

I’m currently creating a lot of classes that will access database using a connection pool.
So I get a connection, create a statement and get the result set. (I can’t use Java 1.7 and the fantastic Automatic Resource Management)
When finishing my method I must finish with a finally block:

        if (rs != null) {
            try {
                rs.close();
            } catch (SQLException sqle) {
                logger.error("Couldn't close result set", sqle);
            }
        }
        if (st != null) {
            try {
                st.close();
            } catch (SQLException sqle) {
                logger.error("Couldn't close statement", sqle);
            }
        }
        if (connection != null) {
            try {
                connection.close();
            } catch (SQLException sqle) {
                logger.error("Couldn't close connection", sqle);
            }
        }

I’m already seeing the nightmare it will be for XX classes having 4/5 methods each.

Would it be good practice to make an helper class which would got a special close method for each object type like :

public static void closeResource(Connection connection) {
        if (connection != null) {
            try {
                connection.close();
            } catch (SQLException sqle) {
                logger.error("Couldn't close connection", sqle);
            }
        }

And then just doing my usual finally with xx.close(connection);xx.close(statement);xx.close(rs);

Or in the same thinking (I know at this point I’ll shock some people as I myself find that a bit ackward), having a method like public static void closeResources(Object... obj) {} with an awful list of instanceof ?

Or in your experience, coding the whole thing everywhere is better ?

Answer 1

Use Apache commons project : http://commons.apache.org/dbutils/apidocs/org/apache/commons/dbutils/DbUtils.html

DbUtils.closeQuietly() is probably what you need