Question

I’m currently rewriting an e-shop – but only the client side, i.e. the CMS remains mostly in tact. I am not using a pre-built framework, as the system has to retain backwards compatibility with the CMS and I have to have full freedom of the structure of code.

The new system is purely MVC based and I have a Bootstrapper which loads controllers based on the current uri and the latter use models for the real work – both with sessions and the database.

tl;dr It’s my first project without a pre-built framework.

I am very inexperienced when it comes to design patterns. I know how do most of the popular ones work but have had never put them to use.

Now I am suspecting code smells because all of my models are classes that consist purely of static methods. I can find no advantages of doing them in a different manner. I routinely need some of the methods in various places through out the code. I.e. I need to fetch the logged in user in the main layout, check user rights to see current page in the bootstraper, display user panel by the controller. I’d need to re-instantiate an object each time or keep a global one if I wasn’t using statics. There also won’t be a need for more than one such class at a time.

I must be missing something, because even though I use OOP, some my classes are just meaningless containers for their methods (and sometimes a couple of private variables). I could have just been using PHP4 and simple functions.

Any comments or advice would be highly appreciated.

EDIT: in spite of all these educated answers, I remain unconvinced. Even though it’s most probably because of my lack of experience, I still don’t foresee anything going wrong with the current setup. I mean I don’t even fathom a situation where I’d have any inconveniences due to the code architecture as it is now. I hope I don’t get a harsh lesson when it’s too late to change anything…

Answer 1

You are right, it’s a code smell and everybody will tell you it’s baaaad.

So here I suggest rather to make a self-assessment of the severity of the problem:

• Do you have classes with many getter and setter?

• Are your static functions like the one below?

  If yes, try to move the logic in the class MyClass that will be already way more OO. That’s a classic mistake from procedural/scripting world.

---

 static void myMethod( MyClass anObject )
 {
     // get value from anObject
     // do some business logic
     // set value of anObject
 }

---

• Do you have a lot of global state, such as data you fetch from the current session?

  If yes, make an assessment whether you want to change it. The OO way would be to pass the session down the call chain. But in practice, it’s convenient to access the session as a global object. But it impedes testability. Try to remove some global state and turn that into regular object that you pass and manipulate in methods.

Make this assessment, and try to identify utility classes, services classes and the business objects. Utility class are helper classes with utility methods (e.g. formatting, conversion, etc.) which can be static. Service class do some business logic but they should be stateless and one instance suffice. Business objects are user, products, article, etc. is where you must concentrate your effort. Try to turn plain data into objects with embed some behavior.

Have a look at should entity be dumb. Even if it’s for java, the concepts are general.

EDIT

Here is my analysis based on your comment:

• You don’t have a domain model with entities. You manipulate the database directly.
• What you call your model, is what I call services and is where you perform the business logic that manipulate data. Service classes are stateless, which is correct. As you pointed out in the question, you then either need to constantly re-create them, create one global instance, or use static methods.

The OO paradigm would say that you should try to have a domain model where you map your database with entities. At least have an anemic domain model where entities are dull data container that are loaded/persisted in database. Then the OO paradigm would also say to put a bit of logic in the entities if possible.

It would also say to turn the services into objects to ease composition and reuse. If it was the case you could for instance wrap all services with an interceptor to start/stop transactions or do some security check, which you won’t be able to do with static methods.

What you describe (no entities + stateless procedural services) is not considered a great OO design. I would suggest you introduce an anemic domain model at least and DAO. Regarding the sateless procedural services, this is actually the reality of many web applications — if you don’t need more you can stick to it.

My 2 cents