Question

I’m developing a service that is being injected a Logger object but I can have 2 different kind of loggers, I’m planning on having a syslog logger and a queue message system logger. Is this possible?

The idea is having an interface:

interface Loggable
{
    public function log() ;
}

and 2 classes that implement that interface:

class Syslogger implements Loggable
{
    public function log()
    {
        ...
    }
}

class QMSLogger implements Loggable
{
    public function log($queueName)
    {
        ...
    }
}

The only way I could come with is having an array as a parameter and use it on one class and not using on the other one… but that is a little bit smelly 😛

Answer 1

As stated in the comments, that’s not the same interface. If you cannot generalize the interface across all possible logger implementations, make the configuration differences part of the instance constructor:

class QMSLogger implements Loggable {

    protected $queueName;

    public function __construct($queueName) {
        $this->queueName = $queueName;
    }

    public function log() {
        ...
    }

}