Question

Im dismissing progress dialog when AsyncTask is finished. Should i check isShowing before dismissing it?

I’ve tried remove this check and it works normally, but may be there are hidden traps?

if (progressDialog.isShowing()) {
  progressDialog.dismiss();
}

Answer 1

Is seems that is checked inside implementation:

public void dismiss() {
    if (Thread.currentThread() != mUiThread) {
        mHandler.post(mDismissAction);
    } else {
        mDismissAction.run();
    }
}

private void dismissDialog() {
    if (mDecor == null || !mShowing) {
        return;
    }

    try {
        mWindowManager.removeView(mDecor);
    } finally {
        mDecor = null;
        mWindow.closeAllPanels();
        onStop();
        mShowing = false;

        sendDismissMessage();
    }
}