Question

I’m exposing some CRUD methods through WCF service, for some data objects persisted in a database through NHibernate. Is it a good approach to use NHibernate classes as data contracts, or is it better to wrap them or replace them with some other data contracts? What is your approach?

Answer 1

Our team just went through a good few months debating this design point, so I’ve got a lot of links to share 😉

Short answer: You “should” translate from your NHibernate classes into a domain model.

Long answer: I think the answer to this is a matter of principle. If you ever want to be interoperable, you should not use Datasets as your DTOs (I love Hanselman’s post on this). I’m not saying that it’s never a good idea; clearly people have had success doing so. Just know that you are cutting corners and it’s a risky proposition.

If you have complete control over the classes you are pushing the data into, you could build a nice domain model and just map the NHibernate data into those classes. You will more than likely have serious issues doing that, as IList<> (which a <bag> maps to) is not serializeable. You’d have to write your own serializer, or use something like NetDataContractSerializer, but you lose interoperability.

You will need to measure the amount of work involved in building some wrapper classes, and the translation between, but then you have complete flexibility in what your domain model will look like. Then, you’re able to do things (as we have done) like code generation for your NHibernate maps and objects. Then, your data contracts serve as an abstraction from your data, as they should.

P.S. You might want to take a look at ADO.NET Data Services, which is a RESTful way to expose your data, which, at this point, seems to be the most interoperable choice to expose your data.