Question

I’m getting two contradicting Exceptions when creating and populating my new SQLiteDatabase in Android. In short my code:

SQLiteOpenHelper extending class:

public void onCreate(SQLiteDatabase db) {
    db.execSQL(DB_TABLE_CREATE);
    loadLevelData(db); //puts data in the database
    //db.close(); <<< ?
}

In my activity class I instantiate this class (in onCreate()), and call getWritableDatabase():

dbHelper = new DbOpenHelper(getApplicationContext());
database = dbHelper.getWritableDatabase();  

Now if I don’t call db.close() after populating the database, like above, I get

android.database.sqlite.DatabaseObjectNotClosedException: Application did not close the   cursor or database object that was opened here  

However if I DO close it, I get the following exception:

java.lang.IllegalStateException: database not open

on getWritableDatabase().

This really confuses me, so could anyone help me with what’s wrong?

Answer 1

You are not expected to close the database in the DatabaseHelper class. However you need to close it every time you open it calling getWritableDatabase:

dbHelper = new DbOpenHelper(getApplicationContext());
database = dbHelper.getWritableDatabase();
//... do something with database
database.close();