Question

I’m having a bit of trouble getting my head around referencing self within a block, and not creating a retain cycle.

Can you let me know if my understanding is correct:

If I ever reference self within a block, it will create a retain cycle, and instead I should be creating a weak reference to self outside of the block and then using that weak reference inside the block?

Thanks!

Answer 1

Yes, that is correct, with a few exceptions:

A retain cycle only happens if self ends up retaining the block indirectly, e.g. setting property myblock on property of self myproperty:

self.myproperty.myblock = ^{ [self dosomething]; }; // ERROR: Retain Cycle

However, a retain cycle doesn’t (usually) happen when using blocks for something like dispatch code, like this:

dispatch_async(dispatch_get_main_queue(), ^{ [self dosomething]; }); // Safe, dispatch_async will not be retained by you

Unless of course you call that dispatch_async function inside a block that has the criteria for being a retain cycle.

It is really confusing, and it’s something I hope gets fixed. Now, for my own opinion:

---

It wasn’t always the case, in pre-ARC code this wasn’t an issue, but since blocks now automatically retain any objects they capture, it’s an issue.

I wish this would get fixed, as it’d be a quite easy fix, by having self‘s type be a __weak instancetype const instead of a instancetype const. It would also solve some issues with creating class clusters in ARC, which admittedly isn’t the largest of issues, but it still exists.

As far as advantages to retain cycles, there are not many.