Question

I’m having a issue with the following scenario on Windows Forms:

I created a Form with two buttons, each button have been assigned with the behaviour DialogResult OK and DialogResult Cancel, respectively.
But based on certain conditions, I need to stop the execution of the OK button. The problem is that if I just made a return like this:

private void btnOk_Click(object sender, EventArgs e)
    {
        foreach(Control control in tblTable.Controls)
        {
            if (control.GetType() == typeof(TextBox))
            {
                 if (control.Text.Trim() == "")
                 {
                     control.Focus(); return;
                 }
            }
            else
            {

            }
        }
    }

The dialog result keeps returning the OK answer to the parent form.

I need to stop the execution of the event and not return any answer until the user corrects the info on the form. In other words, the user should be taken back to the form to correct any missing or wrong data.

Answer 1

Personally I wouldn’t use DialogResults on buttons in this scenario. I only tend to set the DialogResult when there’s only distinct options that do not require any additional logic (i.e. making a custom MessageBox).

What I would do is to just send the DialogResult yourself on success:

private void btnOk_Click(object sender, EventArgs e)
{
    if (allIsOK())
    {
        this.DialogResult = DialogResult.OK;
    }
}