Question

I’m having a syntax issue with this bit of code:

$query = "SELECT *
        FROM ".$db->nameQuote('#__mls')."
        WHERE 1=1"
            . if ($zip != null)
                { AND ".$db->nameQuote('MSTZIP')." = ".$db->quote($zip)."}
            . if ($city != null)
                { AND ".$db->nameQuote('MSTCITY')." = '".$db->quote($city)."'}
            . if ($bdrms != null)
                { AND ".$db->nameQuote('MSTBDRMS')." >= ".$db->quote($bdrms)."}
            . if ($bths != null)
                { AND ".$db->nameQuote('MSTBATHS')." >= ".$db->quote($bths)."}
            . if ($lprice != null)
                { AND ".$db->nameQuote('MSTLISTPRC')." BETWEEN ".$db->quote($lprice)." AND ".$db->quote($hprice)."} 
        ";"
    ;

First string " starts the query statement, second " layer assigns the table, when the WHERE statement, then it gets tricky. All the if statements are messing with me. I feel like that’s where a " is getting misplaced or missing.

Answer 1

Utterly broken beyond belief. Try something more like this:

$query = "SELECT * FROM " . $db->nameQuote('#__mls') . " WHERE 1=1";
$clauses = array();
if ($zip != null) {
   $clauses[] = $db->nameQuote('MSTZIP') . " = " . $db->quote($zip);
}
if (etc...) {
   ... 
}
$query .= implode(' AND ', $clauses);
echo $query;