Question

I’m having an issue with using SHGetFileInfo on the public desktop and files in the public desktop. I’ll focus on the actual desktop folder (CSIDL_COMMON_DESKTOPDIRECTORY or usually “C:\Users\Public\Desktop”). Also – I’ve started seeing this behavior only recently, but I can’t pinpoint the exact change which made it faulty. The actual call to ShGetFileInfo has not changed (as far as I can tell).

So I have this (I’ve omitted intermediate error checks to shorten – the function calls return with success):

SHFILEINFOW info;
uint32_t return_value = 0;
uint32_t flags = SHGFI_TYPENAME|SHGFI_ICON|SHGFI_SMALLICON|SHGFI_SYSICONINDEX;
uint32_t attributes = FILE_ATTRIBUTE_NORMAL;
wchar_t *path = L"C:\\Users\\Public\\Desktop";
return_value = SHGetFileInfoW(path, attributes, &info, sizeof(SHFILEINFOW), flags);

printf("[%ls] %u ", path, return_value);

This returns 0 as the return value. If I populate path using:

SHGetFolderPathW(NULL, CSIDL_COMMON_DESKTOPDIRECTORY, NULL, 0, path)

I get the same result. But if I use the pidl, as in:

LPITEMIDLIST pidl = NULL;
SHGetSpecialFolderLocation(NULL, CSIDL_COMMON_DESKTOPDIRECTORY,  &pidl);
return_value = SHGetFileInfoW((LPCWSTR) pidl, attributes, &info, sizeof(SHFILEINFOW), flags | SHGFI_PIDL);

Then I get something which I expect, a handle to the system small icon list.

I can’t tell what I’m doing wrong – and it only happens on this specific folder. I actually need icons for the items inside the directory, so using the pidl doesn’t seem to be an option right now. Any ideas on what is the expected way to retrieve icons from the common desktop?

—

I should mention this behavior happens on Windows Vista – using the path populated by SHGetFolderPathW on XP works fine

Answer 1

I had the same problem. It can be fixed by calling the function CoInitialize from OLE32.DLL when the program starts.

CoInitialize(0);
return_value = SHGetFileInfoW(path, attributes, &info, sizeof(SHFILEINFOW), flags);