Question

I’m having problems with a leak in the init method of a class I have created. To keep it simple, I have the following (simplified) problem:

• ViewController initialises an instance of
• ClipData class which initialises an instance of
• AnimationData class which initialise a string

ViewController:

myClipData = [[ClipData alloc] init];

ClipData:

- (id)init
{
    self = [super init];
    if (self) {
        animData = [[AnimationData alloc] init];  //LEAK HERE
    }

    return self;
}

AnimationData:

- (id)init
{
    self = [super init];
    if (self) {
        name = [NSString string];
    }

    return self;
}

All the objects in the classes are declared as (nonatomic, retain). I’m aware that doing this bumps up the retain count, but how do I initialise the AnimationData without leaking the animData???

Probably a very stupid question, so any help much appreciated.

Thanks,
Duncs

Answer 1

You are never releasing the animData. You need to add dealloc to your class:

- (void)dealloc {
  [animData release];

  [super dealloc];
}

Similarly, you need to add a similar dealloc to AnimationData.

On a related note, you need to retain and later release the string created in -[AnimationData init], what you are doing right now is essentially a noop, except that it leaves behind a garbled pointer.