Home/ Questions/Q 6605471
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-25T19:17:17+00:00

Im having some problems in the way a present an error mensage to my

  • 0

Im having some problems in the way a present an error mensage to my users. I “solved” the problem using two Goto instructions. Please take a look of the code:

<?php require_once("registration/include/membersite_config.php"); ?>
    <!DOCTYPE html>
    <html lang="en">
    <head><?php include_once("parts/head.php"); ?></head>
<body>
<div id="footerfix">
<?php include_once("parts/header.php"); ?>
    <div class="container">
        <div class="hero-unit">
<?php
if (isset($_GET['i'])) {
    unlink("users/thumbs/" . $_SESSION["user_code"] . ".jpg");
    header('Location: profile.php?i=mycv');
}
if (isset($_FILES['avatar']['tmp_name'])) {
    $file_ext = end(explode('.', $_FILES['avatar']['name']));
    if (in_array($file_ext, array('jpg', 'jpeg', 'png', 'gif')) == false) {
        echo("<h2>Error!</h2><p>Your profile photo have to be a picture file.</p>");
        goto nomore;
    }
    $src_size = getimagesize($_FILES['avatar']['tmp_name']);
    if ($src_size['mime'] == 'image/jpeg') {
        $src_img = imagecreatefromjpeg($_FILES['avatar']['tmp_name']);
    } elseif ($src_size['mime'] == 'image/png') {
        $src_img = imagecreatefrompng($_FILES['avatar']['tmp_name']);
    } elseif ($src_size['mime'] == 'image/gif') {
        $src_img = imagecreatefromgif($_FILES['avatar']['tmp_name']);
    } else {
        echo("<h2>Error!</h2><p>Incorrect file format.</p>");
        goto nomore;
    }
    $thumb_w = 150;
    if ($src_size[0] <= $thumb_w) {
        $thumb = $src_img;
    } else {
        $new_size[0] = $thumb_w;
        $new_size[1] = ($src_size[1] / $src_size[0]) * $thumb_w;
        $thumb = imagecreatetruecolor($new_size[0], $new_size[1]);
        imagecopyresampled($thumb, $src_img, 0, 0, 0, 0, $new_size[0], $new_size[1], $src_size[0], $src_size[1]);
    }
    imagejpeg($thumb, "users/thumbs/" . $_SESSION["user_code"] . ".jpg");
    //header('Location: profile.php?i=mycv');
    echo('<h2>Ready!</h2><p>Your profile picture is updated. <a href="profile.php">Go back</a>.</p>');
    nomore:
    echo "</div></div>";
    include_once("parts/footer.php");
    echo "</div></body></html>";
}
?>

I never understood why goto is the worst think that could happened to a code (at least, every one says that), i will like to hear your opinions about this, and if that is really the worst think ever, how still use my code whitout them? Thanks!

enter image description here

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    The short answers why GOTO is a bad idea: readability suffers. Consider this:

    <?php require_once("registration/include/membersite_config.php"); ?>
<!DOCTYPE html>
<html lang="en">
<head><?php include_once("parts/head.php"); ?></head>
  <body><div id="footerfix">
  <?php include_once("parts/header.php"); ?>
    <div class="container">
      <div class="hero-unit">
<?php
if(isset($_GET['i'])){ unlink("users/thumbs/".$_SESSION["user_code"].".jpg"); header('Location: profile.php?i=mycv');}
if(isset($_FILES['avatar']['tmp_name'])){
    $file_ext = end(explode('.',$_FILES['avatar']['name']));
    if(in_array($file_ext,array('jpg','jpeg','png','gif'))==false){
        echo("<h2>Error!</h2><p>Your profile photo have to be a picture file.</p>");
    }
    else {
        $src_size=getimagesize($_FILES['avatar']['tmp_name']);
        if($src_size['mime']=='image/jpeg') {
            $src_img=imagecreatefromjpeg($_FILES['avatar']['tmp_name']);
        } elseif($src_size['mime']=='image/png') {
            $src_img=imagecreatefrompng($_FILES['avatar']['tmp_name']);
        } elseif($src_size['mime']=='image/gif') {
            $src_img=imagecreatefromgif($_FILES['avatar']['tmp_name']);
        } else {
            echo("<h2>Error!</h2><p>Incorrect file format.</p>");
        }
        if(!empty($src_img)) {
            $thumb_w = 150;
            if($src_size[0]<=$thumb_w){
                $thumb=$src_img;
            }else{ 
                $new_size[0] = $thumb_w;
                $new_size[1] = ($src_size[1]/$src_size[0])*$thumb_w;
                $thumb=imagecreatetruecolor($new_size[0],$new_size[1]);
                imagecopyresampled($thumb,$src_img,0,0,0,0,$new_size[0],$new_size[1],$src_size[0],$src_size[1]);
            }
            imagejpeg($thumb,"users/thumbs/".$_SESSION["user_code"].".jpg");
            //header('Location: profile.php?i=mycv');
            echo('<h2>Ready!</h2><p>Your profile picture is updated. <a href="profile.php">Go back</a>.</p>');
        }
    }
}
?>
    </div></div>
    <?php include_once("parts/footer.php"); ?>
</div>
</body>
</html>

    Anyway, you should consider separating your template from logic (google “MVC”) and use at least functions for complex operations.

    • 0