Question

I’m looking for the best Design for the following situation.

We have many objects form one class, for instance a picture frame. Now each of the picture frames can display 3 types of picture. 1) a face 2) a screenshot 3) empty

Thats easy:

public enum PictureMode  {     Face,     Screen,     None }  public class PictureFrame {     private PictureMode mode;     public PictureMode Mode      {         get { retrun mode; }         set { /* set currentPicture to the correct one */ }     }      private Image currentPicture;     private Image face;     private Image screen;     private Image empty;      public PictureFrame(Image face, Image screen) {         this.face = face;         this.screen = screen;          mode = PictureMode.None; // Maybe this is our default.     } } 

We can now create some PictureFrames with different pictures and easily change the mode for each one.

Now I want to add a global setter for all PictureFrames. Then each new PictureFrame should take the global setting as the default one. It can later be set to an different through.

Here is my solution, but I want to discuss if there is a better one.

I added a static field PictureFrame.Instances to the PictureFrame class where all PictureFrames are reachable. Now I can iterate over all the PictureFrames to apply the new global mode to all frames.

In addition I have a second static field PictureFrame.GlobalImageMode where I set the global mode if I change it on all Frames and read it in the Constructor of the PictureFrame. The setter for the GlobalImageMode can be static in the PictureFrame class, too.

Answer 1

Just wild shot here…: Why don’t you always use getter for current frame mode with a condition in it:

class PictureFrame {   private PictureMode instanceMode;   private static PictureMode? globalMode;    private PictureMode CurrentMode {     get {        return globalMode ?? instanceMode;     }   } }