Question

I’m new to Objective-C and can’t seem to get the memory management code right. I have the following code:

Media* myMedia = [self.myMediaManager getNextMedia];

self.navigationItem.title = [self.myMediaManager getCategory];
[self.btnImage setImage:myMedia.imageFile forState: UIControlStateNormal];
[self.lblImage setText:myMedia.imageLabel];

//[myMedia release];

My app crashes if I uncomment the above line. Do I need to do something special when I instantiate myMedia?

EDIT:

If myMediaManager is supposed to release it, when would it do that. Here is my code for getNextMedia:

- (Media*) getNextMedia {

    DLog(@"Start");

    Media* nextMedia = [[Media alloc] init];

    [self setNextMediaIndex];

    if (self.mediaIndex > -1)
    {
        nextMedia = [mediaArray objectAtIndex: self.mediaIndex];
    }

    return nextMedia;
}

EDIT2: I fixed the crashing issue (I was releasing an object I didn’t own). I still see leaks and can’t seem to find what the issue is.

Answer 1

Only objects that you own can be released.

You can release objects if you new, alloc, copy, mutableCopy or retain them first.

Since there is no alloc/copy/retain in [self.myMediaManager getNextMedia]; you can’t release it.