Question

I’m new to OOP terminology, I am trying to create a class that make a hit counter.

I try the code below but it create just a counter.txt page with inside value 1. I dont know why its not incrementing.

class LOGFILE {
    public function READ($FileName) {
        $handle = fopen($FileName, 'r');
        $fread = file_get_contents($FileName);
        return $fread;
        fclose($handle);
    }
    public function WRITE($FileName, $FileData) {
        $handle = fopen($FileName, 'w');
        $FileData = $fread +1;
        fwrite($handle, $FileData);
        fclose($handle);
    }
}
$logfile = new LOGFILE();

$logfile -> WRITE("counter.txt",$FileData);

echo $logfile -> READ("counter.txt");

Answer 1

The reason is that $fread is local variable for both READ and WRITE methods. You need to make it private global variable for your class:

class LOGFILE {
    private $fread;

    public function READ($FileName) {
        $this->fread = file_get_contents($FileName);
        return $this->fread; 
    }
    public function WRITE($FileName) {
            $this->READ($FileName);
        $handle = fopen($FileName, 'w');
        $FileData = $this->fread +1;
        fwrite($handle, $FileData);
        fclose($handle);
    }
}
$logfile = new LOGFILE();

$logfile -> WRITE("counter.txt");

echo $logfile -> READ("counter.txt");

Note: I have removed fopen and fclose because file_get_contents does not need it. In write you can use file_put_contents. Removed not used variable $FileData too. It’s always a good practice to create variables methods and classes when they are needed.

Also take a look at best practices how to name your classes, variables, methods and so on. Here’s best guide, IMO.