Question

Im new to ruby, wrote this code and works but i know is not the most elegant way to do it, can you please help me to refactor it in the ruby way¡

  #Ckeck that is not a repetead user
  next if Profile.exists?(:screen_name => t.from_user) 
  next if SearchResults.exists?(:username => t.from_user)
  next if usernames.include? t.from_user

Answer 1

I think your method is fine but personally, I would do something like this (with the info provided) …

Use reject to limit your collection to the desired elements.

def repeat_user(user, usernames)
  Profile.exists?(:screen_name => user.from_user)    ||
  SearchResults.exists?(:username => user.from_user) ||
  usernames.include? user.from_user
end

User.all.reject{ |user| repeat_user user, usernames }.each do |user|
  # do your stuff here
end