Question

I’m new to Visual Studio 2010 and MySQL. I’m creating a form where the user will enter the information to be added in the database. No errors occur, however when I check MySQL the data that I’ve entered was not saved in my database. Can someone check my code for errors or lack of correctness? Please help. Thanks.

Here’s my code:

private void button_adduser_Click(object sender, EventArgs e)
    {
        string MyConString = "SERVER=localhost;" + "DATABASE=timekeeping;" + "UID=root;" + "PASSWORD=admin;";
        MySqlConnection connection = new MySqlConnection(MyConString);
        MySqlCommand command = connection.CreateCommand();
        command.Connection = connection;

        command.CommandText = "insert into users(addfname, addmname, addlname, addposition, addcontact, addemail, addbday, addusername, addpassword) values(@fname, @mname, @lname, @position, @contactnumber, @emailadd, @birthday, @username, @password)";
        command.Parameters.Add(new MySqlParameter("@fname", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@mname", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@lname", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@position", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@contactnumber", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@emailadd", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@birthday", SqlDbType.Date));
        command.Parameters.Add(new MySqlParameter("@username", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@password", SqlDbType.VarChar));
        command.Parameters["@fname"].Value = addfname.Text.ToLower();
        command.Parameters["@mname"].Value = addmname.Text.ToLower();
        command.Parameters["@lname"].Value = addlname.Text.ToLower();
        command.Parameters["@position"].Value = addposition.Text;
        command.Parameters["@contactnumber"].Value = addcontact.Text;
        command.Parameters["@emailadd"].Value = addemail.Text;
        command.Parameters["@birthday"].Value = addbday.Text;
        command.Parameters["@username"].Value = addusername.Text;
        command.Parameters["@password"].Value = addpassword.Text;
        connection.Open();

        MessageBox.Show("Data Saved");

    }

Answer 1

Try using command.ExecuteNonQuery(). Also note that you can use command.ExecuteScalar() if you are returning a single value (for instance, the ID of the newly inserted record). You should also use the using statement to ensure that the Dispose methods are called for the command and the connection. The entire code should look something like this:

using(MySqlConnection connection = new MySqlConnection(MyConString))
{
    connection.Open();
    using(MySqlCommand command = connection.CreateCommand())
    {
        command.CommandText = "insert into users(addfname, addmname, addlname, addposition, addcontact, addemail, addbday, addusername, addpassword) values(@fname, @mname, @lname, @position, @contactnumber, @emailadd, @birthday, @username, @password)";
        command.Parameters.Add(new MySqlParameter("@fname", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@mname", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@lname", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@position", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@contactnumber", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@emailadd", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@birthday", SqlDbType.Date));
        command.Parameters.Add(new MySqlParameter("@username", SqlDbType.VarChar));
        command.Parameters.Add(new MySqlParameter("@password", SqlDbType.VarChar));
        command.Parameters["@fname"].Value = addfname.Text.ToLower();
        command.Parameters["@mname"].Value = addmname.Text.ToLower();
        command.Parameters["@lname"].Value = addlname.Text.ToLower();
        command.Parameters["@position"].Value = addposition.Text;
        command.Parameters["@contactnumber"].Value = addcontact.Text;
        command.Parameters["@emailadd"].Value = addemail.Text;
        command.Parameters["@birthday"].Value = addbday.Text;
        command.Parameters["@username"].Value = addusername.Text;
        command.Parameters["@password"].Value = addpassword.Text;

        //Execute command
        command.ExecuteNonQuery();
    }
}