Question

I’m retrieving data from a MySQL db and creating reports from it. I need to get counts when certain conditions are met, and since db queries are rather expensive (and I will have a lot of traffic), I’m looping thru the results from a single query in order to increment a counter.

It seems like it’s working (the counter is incrementing) and the results are somewhat close, but the counters are not correct.

At the moment, there are 411 records in the table, but I’m getting numbers like 934 from a ['total'] counter and 927 for ['males'], and that definitely can’t be right. However, I get 4 from ['females'], which is correct…

I’m pretty sure it was working last night, but now it’s not—I’m quite baffled. (there are still just 411 records)

$surveydata = mysql_query("SELECT `age`,`e_part`,`gender` FROM $db_surveydata;") or die(mysql_error());
$rowcount = mysql_num_rows($surveydata);
$age=array('18+'=>0,'<18'=>0,'total'=>0);
$e_part=array('yes'=>0,'no'=>0,'total'=>0);
$genders=array('male'=>0,'female'=>0,'trans'=>0,'don\'t know'=>0,'total'=>0);

while ($responses = mysql_fetch_assoc($surveydata)) {
    foreach ($responses as $response){
        switch ($response){
            case $responses['age']:
                if ($responses['age'] > 18) {$age['18+']++;$age['total']++;}
                // i tried putting the ['total'] incrementer in the if/else
                // just in case, but same result
                else {$age['<18']++;$age['total']++;}
                break;
            case $responses['e_part']:
                if ($responses['e_part']) {$e_part['yes']++;}
                else {$e_part['no']++;}
                $e_part['total']++;
                break;
            case $responses['gender']:
                switch ($responses['gender']){
                    case 1:$genders['male']++;break;
                    case 2:$genders['female']++;break;
                    case 3:$genders['trans']++;break;
                    case 9:$genders['don\'t know']++;break;
                    default:break;
                }
                $genders['total']++;
                break;
            default:break;
        } // end switch
    } //end for
} // end while

thanks!

Answer 1

this is the problem:

foreach ($responses as $response){
        switch ($response){
            case $responses['age']:

switch $responses looks for match

foreach ($responses as $k=>$v){
    switch ($k){
        case 'age':
            if ($v > 18) ....