Home/ Questions/Q 8212447
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-06-07T10:45:41+00:00

I’m starting in JS and have been having trouble with a particular function I’m

  • 0

I’m starting in JS and have been having trouble with a particular function I’m trying to write. The purpose is to have the text change once the button is pressed. The “nothing” text should change into “You say hi, I say Hey?” With the Hey? being text already on the document.

Here’s the code, any pointers would be welcome!

<html>
<head>
<title>Javascript test </title>
</head>

<body>

<p id="hey">Hey?</p>
<p id ="nothing">Nothing</p>
<INPUT type =button VALUE="Button?" OnClick=(take())>

<script>
function take(){
var hey=document.getElementById("hey");
var nothing =document.getElementById("one");

nothing.appendChild(document.createTextNode("You say hi, I say " + hey));
}
</script>
</body>
</html>

Alright, thanks for all the help guys. No one in particular was 100% right but i tried a combination of all the suggestions and got about 99% of the way to where i wanted to go. My code looks like this now. The last change im trying to make is not to append new text strings but to replace the old string with the string that is currently being appended.

<html>
<head>
<title>Javascript test </title>
</head>

<body>

<p id="hey">Hey?</p>
<p id ="nothing">Nothing</p>
<input type ="button" value="Button?" OnClick="take();"/>

<script>
function take(){
var hey=document.getElementById("hey");
var nothing =document.getElementById("nothing");

nothing.appendChild(document.createTextNode("You say hi, I say " + hey.innerHTML));

}

</script>
</body>
</html>

I appreciate the help, thank you Stack Overflow community!

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    Your code has a few issues.

    First, you should specify type="text/javascript" on your script tag.

    Second, your input should look like this:

    <input id="button" type="button" value="Button?" />

    Third, you should bind your event handler in the script tag (See SoC):

    document.getElementById('button').onclick = take;

    Fourth, your function looks for an element with id one, which does not exist. Did you mean id nothing instead?

    Fifth, assuming you use the correct id to get the nothing element, you need to use the value from the other p when setting the value.

    var take = function () {
    var hey = document.getElementById('hey');
    var nothing = document.getElementById('nothing');

    nothing.innerHTML= 'You say hi, I say ' + hey.innerHTML;
};

    See a working example here: http://jsfiddle.net/M5UWn/

    As a side note, I found jQFundamentals an excellent learning site for both jQuery and native javascript.

    • 0