Question

i’m testing my app on Instruments,
and I see that my UIImage and UIImageView are memory-leaking like crazy…

I’m basically using recursion, so same variables get to load different images on each call.

    nextImageName = [[NSString alloc] init];
    nextImageName2 = [[NSString alloc] init];
    nextImageName = [[currentPlayers objectAtIndex:playerIndex] retain];
    nextImageName2 = [[currentPlayers objectAtIndex:(playerIndex+1)] retain];
    nextImage = [[UIImage alloc] init];
    nextImage2 = [[UIImage alloc] init];
    nextImage = [UIImage imageNamed:nextImageName];
    nextImage2 = [UIImage imageNamed:nextImageName2];
    nextImageView = [[UIImageView alloc] init];
    nextImageView2 = [[UIImageView alloc] init];
    nextImageView = [[UIImageView alloc] initWithImage:nextImage];
    nextImageView2 = [[UIImageView alloc] initWithImage:nextImage2];
    NSLog(@"r:%d",currentRound);
    NSLog(@"%d vs. %d", playerIndex, playerIndex+1);

    buttonOne = [[UIButton alloc] init];
    buttonTwo = [[UIButton alloc] init];

    playerOne = nextImageView;
    playerTwo = nextImageView2;
    playerOne.frame = CGRectMake(180.0, 200.0, 275.0, 275.0);
    playerTwo.frame = CGRectMake(550.0, 200, 275.0, 275.0);
    buttonOne.frame = CGRectMake(180.0, 200.0, 275.0, 275.0);
    buttonTwo.frame = CGRectMake(550.0, 200.0, 275.0, 275.0);
    [buttonOne addTarget:self action:@selector(announceWinner:)
        forControlEvents:UIControlEventTouchUpInside];
    [buttonTwo addTarget:self action:@selector(announceWinner2:)
        forControlEvents:UIControlEventTouchUpInside];

Could anyone please help me? This is driving me nuts..

I originally had release for all the variables at dealloc, but it seemed it didn’t go into dealloc, so I also put it in viewDidUnload and didReceiveMemoryWarning.

Answer 1

I think the problem is this:

“I’m basically using recursion, so same variables get to load different images on each call”

…coupled with this:

“I originally had release for all the variables at dealloc, but it seemed it didn’t go into dealloc, so I also put it in viewDidUnload and didReceiveMemoryWarning”

So essentially, if I understand your code correctly, you were making several passes through the alloc/init section over the lifetime of your class, but only ever calling release once, when the class itself is deallocated. I would expect that to leak like crazy.

You should be able to fix it by changing the alloc/init section to follow a pattern like:

if (nextImageName) {
    //if it was previously set, release it so that the old instance doesn't leak
    [nextImageName release];
}
nextImageName = [[NSString alloc] init];

if (nextImageName2) {
    [nextImageName2 release];
}
nextImageName2 = [[NSString alloc] init];

//and so on...

This assumes that these variables are all declared as instance-variables on your class, and that in init you set them all to nil, like so:

- (void) init {
    if ((self = [super init])) {
        //set default values
        nextImageName = nil;
        nextImageName2 = nil;
        //and so on...

        //do other setup things here
    }
}