Question

I’m testing this function in JavaScript Console of FireFox on this website:
http://www.google.com/search?hl=en&tbo=d&output=search&sclient=psy-ab&q=python
And Desired output is just text (.innerHTML) of each link.

    parents = document.getElementsByClassName("r");
    function my_links() {
        links = {};
        for (var i=0; i<parents.length; i++) {
            links[i] = parents[i].getElementsByTagName("a")[0];
        };
        return links;
    }
    elements = my_links();
    for (var i=0; i<elements.length; i++) {
        g_link = elements[i].innerHTML;
        console.log(g_link + "\n");
    }

Answer 1

var parents = document.getElementsByClassName("r");
function my_links() {
    var links = []; // <-- I suppose it should be array and should not be global
    for (var i=0; i<parents.length; i++) {
        // when you're not defining array length then use push instead of indexes
        links.push(parents[i].getElementsByTagName("a")[0]);
    };
    return links;
}

you can do this in more efficient way

function my_links() {
     var links = new Array(parents.length),
         i = parents.length;
     while (i--) {
         links[i] = parents[i].getElementsByTagName("a")[0];
     }
     return links;
}