Question

I’m trying to find out the best way to write my code for better unit testing and such. Currently I have 2 main concerns:

1. I use the service container to get the service I need within a class method, I’m concerned that this may not be the best way to do it as I rely on those services to be ready first
2. I also use a main “settings” class which I can access many settings across modules/plugins. I’m also concerned that this creates an unnecessary dependency on this settings

Some sample code to clarify my issues:

class ABC
{
    function someFunction(){
        if(Container::get('settings')->get('status'))
        {
            Container::get('mailer')->send();
        }
    }
}

Perhaps all I should do is to inject these via the constructor method first?

Answer 1

You could to make the folow:

class ABC
{
    private $_setting = null;
    private $_mailer = null;

    public function setSetting($setting)
    {
        $this->_setting = $setting;
    }

    public function getSetting()
    {
        return $this->_setting;
    }

    public function setMailer($mailer)
    {
        $this->_mailer = $mailer;
    }

    public function getMailer()
    {
        return $this->_mailer;
    }

    function someFunction(){
       if($this->_setting->get('status'))
       {
           $this->_mailer->send();
       }
   }
}

class SettingMock
{
     private $_attributes = array();

     public function setMock($attribute, $value)
     {
         $this->_attributes[$attribute] = $value; 
     }
     public function get($attribute)
     {
         return $this->_attributes[$attribute];
     }

}

class MailerMock
{
    private $_values = array();

    public function setValue($value)
    {
        $this->_values['return'] = $value;
    }

    public function send()
    {
        return $this->_values['return'];
    }
}

The test class:

class FooTest extends PHPUnit_Framework_TestCase
{
    public function testSendMail()
    {
         $settingMock = new SettingMock();
         $settingMock->setMock('status', true);

         $mailerMock = new MailerMock();
         $mailerMock->setValue(true);

         $testObject = new ABC();
         $testObject->setSetting($settingMock);
         $testObject->setMailer($mailerMock);

         $return = $testObject->someFunction();
         $this->assertTrue($return);
    }
}