Question

I’m trying to find the most recent time a contact was marked “done”. Contacts belong to a User. I have this method in my User Model, but I know it can probably be improved.

  def last_contact_done_days
      date_array = self.contacts.find(:all, :select => "date_done").to_a
      most_recent = date_array.max
      last_done_days_ago = Date.today - most_recent[:date_done]
      return last_done_days_ago
  end

Thanks!

Answer 1

You could use this method:

def last_contact_done_days # => date_done of the most recent contact if it exists
  contact = self.contacts.order('date_done DESC').first
  return contact.date_done if contact
  nil
end

OR (shorter version with try method):

def last_contact_done_days
  self.contacts.order('date_done DESC').first.try(:date_done)
end