Question

I’m trying to get a switch to return true or false, but I seem to be failing somewhere. I keep getting false. I’m totally lost. This should have worked actually. How do I get this right?

if (validNum(1))
{echo 'Ok';}else{echo 'Fail';}

function validNum($x)
{
switch ($x)
{
case 1:
  echo "Number 1";
  break;
  return true;

case 2:
  echo "Number 2";
  break;
  return true;
case 3:
  echo "Number 3";
  break;
  return true;

default:
  echo "No number between 1 and 3";
  return false;
}
}

Answer 1

I would rewrite it to below. It merges three cases together and avoids using a break statement that would otherwise go past your switch. Basically, with return you don’t need break.

switch ($x)
{
  case 1:
  case 2:
  case 3:
    echo "Number $x";
    return true;

  default:
    echo "No number between 1 and 3";
    return false;
}