Question

i’m trying to get all images of a post using this method:

$args = array(
    'post_type' => 'attachment',
    'numberposts' => -1,
    'post_status' => null,
    'post_parent' => $post->ID
);  

$attachments = get_posts( $args );
    if ( $attachments ) {
        foreach ( $attachments as $attachment ) {
            $images[] = wp_get_attachment_image_src( $attachment->ID, ATTACHMENT_IMAGE_SIZE );
        }
        return $images;
    }

unfortunately, this will get all images ever uploaded, not just those associated to the current post. i found this post using *get_children*, but it doesn’t work either. any ideas?

ps: i running the code when a post created/updated

Answer 1

You can try

<?php 
        $attachments = get_posts( array(
            'post_type' => 'attachment',
            'posts_per_page' => -1,
            'post_parent' => $post->ID,             
        ) );

        if ( $attachments ) {
            foreach ( $attachments as $attachment ) {
                $class = "post-attachment mime-" . sanitize_title( $attachment->post_mime_type );
                $thumbimg = wp_get_attachment_link( $attachment->ID, 'thumbnail-size', true );
                echo '<li class="' . $class . ' data-design-thumbnail">' . $thumbimg . '</li>';
            }

        }

?>

Read more here.

Make sure $post->ID is not empty.
If this is still not working you can try Extracting Images from the Page / Post content. More details here