Question

I’m trying to get back 2 unique images form an array. Right now I’m refreshing the page until I get 2 unique images. This is not ideal. How can I modify this code to back 2 unique images with out refreshing the page till it hapens.

Can I do it in this layer or do I need to check for unique numbers in the data layer?

 Picture dlPicture = new Picture();
        DataTable DTPictures = dlPicture.GetRandomPicture();
        Picture dlPicture2 = new Picture();
        DataTable DTPictures2 = dlPicture2.GetRandomPicture();



        // the variables to hold the yes and no Id's for each set
        string firstNoPicId = "";
        string firstYesPicId = "";
        string secondNoPicId = "";
        string secondYesPicId = "";

        foreach (DataRow row in DTPictures.Rows)
        {
            firstYesPicId = row["PicID"].ToString();
            secondNoPicId = firstYesPicId;
            FirstPicMemberNameLabel.Text = row["MemberName"].ToString();
            FirstPicLink.ImageUrl = "Pictures/" + row["PicLoc"];

        }

        foreach (DataRow row in DTPictures2.Rows)
        {
            secondYesPicId = row["PicID"].ToString();
            firstNoPicId = secondYesPicId;
            SecondPicMemberNameLabel.Text = row["MemberName"].ToString();
            SecondPicLink.ImageUrl = "Pictures/" + row["PicLoc"];

        }
        if (firstYesPicId != secondYesPicId)
        {

            FirstPicLink.PostBackUrl = "default.aspx?yesId=" + firstYesPicId + "&noId=" + firstNoPicId;
            SecondPicLink.PostBackUrl = "default.aspx?yesId=" + secondYesPicId + "&noId=" + secondNoPicId;
        }
        else
        {
            Response.Redirect("Default.aspx");
        }

Answer 1

Perhaps a better solution would be adding code to your datalayer.GetRandomPicture to make sure it can’t return the same picture twice in a row?

in this Picture class add a LastRandomPictureID variable and do a ‘WHERE NOT ID = LastRandomPictureID’ on your query (you might want to make it a bit more robust to handle the case where only 1 picture exists).