Question

I’m trying to implement AsyncTask outside the activity class. Now the issue is status of this asynctask class is always showing as running, how do i make it finished?

This is my activity class

protected void onCreate(Bundle savedInstanceState) {

    employeeAsyncTask.execute(new String[] {url});

    System.out.println("Status "+employeeAsyncTask.getStatus());
    //employeeAsyncTask.cancel(true);

    while(employeeAsyncTask.getStatus() == AsyncTask.Status.RUNNING){

    }

    while (employeeAsyncTask.getStatus()== AsyncTask.Status.FINISHED)   {
        System.out.println("hereeeeeeeeeeeeee");
        ArrayList<Employee> list = employeeAsyncTask.getEmpList();
        System.out.println("Size of list "+list);
    }

    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_capture);


}

This is my asynctask class

public class FetchEmployeeAsyncTask extends AsyncTask<String, Void, ArrayList>{

private ArrayList<Employee> empList = null;
private boolean done = false;

/**
 * @return the done
 */
public boolean isDone() {
    return done;
}

/**
 * @param done the done to set
 */
public void setDone(boolean done) {
    this.done = done;
}

@Override

protected ArrayList doInBackground(String... url) {
    // TODO Auto-generated method stub
    ArrayList<Employee> employees = null;
    for(String employeeUrl : url){

        employees = fetch(employeeUrl);
    }
    return employees;
}

private ArrayList<Employee> fetch(String url) {
    // TODO Auto-generated method stub
    ArrayList<Employee> employees = null;
    String response = null;
    try {
        DefaultHttpClient httpClient = new DefaultHttpClient();
        HttpGet httpGet = new HttpGet(url);

        HttpResponse httpResponse = httpClient.execute(httpGet);
        HttpEntity httpEntity = httpResponse.getEntity();
        response = EntityUtils.toString(httpEntity);
        employees = EmployeeXMLParser.XMLfromString(response);
        System.out.println("Size in fetch "+employees.size());

        //System.out.println("Employee Name :: " + employees.get(0).getFirstName() + " " + employees.get(0).getLastName());
    } catch (UnsupportedEncodingException e) {
        e.printStackTrace();
    } catch (ClientProtocolException e) {
        e.printStackTrace();
    } catch (IOException e) {
        e.printStackTrace();
    } /*catch (XmlPullParserException e) {
        // TODO Auto-generated catch block
        System.out.println("Error parsing the response :: " + response);
        e.printStackTrace();
    }*/
    return employees;
}

@Override
protected void onPreExecute() {
    // TODO Auto-generated method stub
    super.onPreExecute();
    done = false;
}

@Override
public void onPostExecute(ArrayList employeeList){

    setEmpList(employeeList);
    System.out.println("in post execxute "+employeeList.size());
    done = true;
}

public ArrayList<Employee> getEmpList() {
    return empList;
}

public void setEmpList(ArrayList<Employee> empList) {
    this.empList = empList;
}

}

I’m unable to figure out what should be included in onPostExecute().

Answer 1

Add a constructor that takes the activity as parameter and stores it in a field:

private MyActivity activity;

public FetchEmployeeAsyncTask(MyActivity activity) {
    this.activity = activity;
}

Then in the onPostExecute method you can pass back the employee list:

@Override
public void onPostExecute(ArrayList employeeList) {
    activty.onEmpListLoaded(employeeList);
}

And in your activity implement onEmpListLoaded to do whatever needs to be done.