Question

I’m trying to import an excel file Excel97-2003 (the first sheet only) into an Access database. for that I’m using the following code :

Dim cnnExcel As New ADODB.Connection
Dim rsExcel As New ADODB.Recordset
With cnnExcel
    .Provider = "Microsoft.Jet.OLEDB.4.0"
    .ConnectionString = "Data Source=" & strFileSelected & ";" & "Extended Properties=Excel 8.0"
    .CursorLocation = adUseClient
    .Open
End With

rsExcel.Open "SELECT * FROM [Sheet1]", cnnExcel

All the columns in the excel file are string and have type “General” (no special format) when you open it with Excel2003) and the 3 other columns are dates.
My problem is I get null for value which exist in the cell.For exemple if the first value is string than if there’s an integer in that columns it will be returned as null and vice-versa
Is there any solution for this?

Thank you

Answer 1

Solution 1

Using your code, I was able to properly load data from an Excel Sheet without problem.
However, please check your SQL Query, it should be something like:

rsExcel.Open "SELECT * FROM [Sheet 1$]", cnnExcel

The rules for the FROM part as as follow:

• Query from for an entire worksheet:
  SELECT * FROM [SheetName$], note the $
• Query from a range:
  SELECT * FROM [SheetName$A1:C5]
• Query from a named range:
  SELECT * FROM NameRange
• Query from a worksheet that has non-alphanumerical characters:
  SELECT * FROM ['This;is.My SheetName$']

Code working on my machine:

Dim cnnExcel As Object
Dim rsExcel As Object
Set cnnExcel = CreateObject("ADODB.Connection")
Set rsExcel = CreateObject("ADODB.RecordSet")
With cnnExcel
    .Provider = "Microsoft.Jet.OLEDB.4.0"
    .ConnectionString = "Data Source=D:\Query1.xls;Extended Properties=Excel 8.0"
    .CursorLocation = 3
    .Open
End With

rsExcel.Open "SELECT * FROM [Sheet 1$]", cnnExcel
Debug.Print rsExcel.RecordCount '  Prints the number of rows containing data '
Do
    Debug.Print "Col1: " & rsExcel.Fields(0) & "  - Col2: " & rsExcel.Fields(1)
    rsExcel.MoveNext
Loop While Not rsExcel.EOF
rsExcel.Close

Solution 2

You may have better luck with manipulating the Excel workbook directly.
Let’s assume that you have a table MyTable in your Access database where you want to import in the fields myA, myB and myC (that have the proper datatype you expect!) the content of your Excel Sheet 1 that has corresponding columns.

The simplified VBA code would look like this:

Sub ImportData(fname As String)
    Dim xlo As Object
    Dim xlWb As Object
    Dim xlWs As Object
    Dim colA, colB, ColC As Variant
    Dim db As DAO.Database
    Dim rs As DAO.Recordset
    Dim thereIsData As Boolean
    Dim row As Integer

    ' Open Excel sheet, try to re-use Excel if it is open '
    On Error Resume Next
    Set xlo = GetObject("Excel.Application")
    If xlo Is Nothing Then Set xlo = CreateObject("Excel.Application")
    On Error Goto 0
    Set xlWb = xla.Workbooks.Open(fname)
    Set xlWs = xlWb.Worksheets(1)  ' Sheet 1'

    ' Open table where the results will be stored '
    Set db = CurrentDb()
    Set rs = db.OpenRecordset("MyTable", dbOpenDynaset)
    Do
       colA = xlWs.Cells(row, 1).Value
       colB = xlWs.Cells(row, 2).Value
       colC = xlWs.Cells(row, 3).Value
       ' We will stop at the first empty row '
       thereIsData = Not (IsBlank(colA) And IsBlank(colB) And IsBlank(colC))
       If thereIsData Then
            ' Add the Excel data to the table '
            rs.AddNew
                rs!myA = colA
                rs!myA = colB
                rs!myA = colC
            rs.Update
       End If
       row = row + 1
    Loop While thereIsData
    rs.Close
    ' Cleanup '
    Set rs = Nothing
    Set db = Nothing
    Set xlWs = Nothing
    Set xlWb = Nothing
    xla.DisplayAlerts = False
    xla.Quit
    Set xls = Nothing
End Sub

'-----------------------------------------------------------------------------  
' True if the argument is Nothing, Null, Empty, Missing or an empty string .  
'-----------------------------------------------------------------------------  
Public Function IsBlank(arg As Variant) As Boolean  
    Select Case VarType(arg)  
        Case vbEmpty  
            IsBlank = True  
        Case vbNull  
            IsBlank = True  
        Case vbString  
            IsBlank = (arg = vbNullString)  
        Case vbObject  
            IsBlank = (arg Is Nothing)  
        Case Else  
            IsBlank = IsMissing(arg)  
    End Select  
End Function