Question

I’m trying to pass through three variables (artistID, albumID and currently selected value) to function player but I keep getting an error each time I try this:

var carry_else = 'actorID,movieID,this.value'

This is the code as it stands I have been trying to edit var carry_else to no success:

actorID = movie_select.substring(0, movie_select.indexOf(':'));
movieID = movie_select.substring(movie_select.indexOf(':')+1, movie_select.length); 

// this line needs to be edited to var carry_else = 'actorID,movieID,this.value' but doing this doesn't work    
var carry_else = 'this.value,this.value,this.value' 
hstr+="<form><select size='"+count+"' onChange='parent.info(" + carry_else + ");'>";

How can I solve this issue?

Answer 1

Since actorID and movieID appear to be strings, why not put them in as literals:

function escapeHtml(str) {
  return str.replace(/&/g,'&amp;').replace(/>/g,'&gt;').replace(/</g,'&lt;').replace(/"/g,'&quot;');
};
function quoteString(str) {
  return '"'+str.replace(/"/g,'\\"')+'"';
}

hstr+="<form><select size='"+count+"' onChange='parent.info("+escapeHtml(quoteString(actorID))+","+escapeHtml(quoteString(movieID))+",this.value);'>";

If available, I’d use JSON.stringify() instead of the quoteString function I put above.